feat: support evaluated rspfile in command
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In ninja, the variable lookup is recursive, and has cycle detection, which is missing from this PR. |
|
@Colecf Thank you for the direction, I can try to dig in ninja's code and port enough related feature and unit tests in my spare time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hacked some code to fix my issue #119 and managed to build my local project using n2.
I'm not familiar with Rust and ninja, so my implementation may be far from suitable, but still I want to open this PR to fill in some unittest of the issue and hopefully someone with a better understanding of this project can make it right both in performance and extendability.