-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated hubot initialization #33
Open
frozenfoxx
wants to merge
40
commits into
evenup:master
Choose a base branch
from
frozenfoxx:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ensuring resources "yo" and "generator-hubot" to update functionality.
Fixed the Hubot init exec statement for updated hubot functionality.
Adjusted the command to reflect what the current command output should be.
Updated the Travis configuration to look more like the PuppetLabs projects' configuration. Ruby 1.8.7 doesn't appear to be relevant for testing anymore.
Added symlink for hubot due to installation by yeoman to /usr/bin/. This can likely be better updated but gets it running for now.
Version was hardcoded.
Sourced the module variable "hubot_version" for the template.
Added creation of the bin directory.
Added explicit options to support Yeoman's automation.
Removed yeoman asking for insight since it breaks automation.
Directory "test" did not always work on all platforms the same way. In addition the directory is already created based on the prior requirement.
Had a bug where the Hubot init would run every time.
- code for systemd in RedHat7/Centos7 - some syntax corrections - changes should not affect on Ubuntu OS (was not tested) - please review and test Changes to be committed: - modified: manifests/config.pp - modified: manifests/init.pp - modified: manifests/install.pp - modified: manifests/params.pp - modified: templates/hubot.env.erb - new file: templates/hubot.systemd.erb
[hubot_systemd]
Everything else about this bot is done as the user hubot. This changes makes it so that the hubot user is who runs the service instead of root.
Run the service as the service account
…ent-variables Ability to toggle on/off show_diff of environment file
Added explicit setting of Ubuntu and Debian $init_style. Older than 14.04 Ubuntu was set to `upstart` and older Debian than 8.0 was set to `debian`. If later, both are set to `systemd`.
setting the service provider for hubot service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix issue #30. I've altered the installation to make sure yeoman and the hubot generator are installed if they are not already, then modified the config.pp to use the new yeoman method of installation.
The path is longer for more accomodation but in the future this really should be a variable set on operating system.
Reopened from this pull request due to Travis not recognizing new changes.