URL encode the "#" character in SVG data url #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The todo-list checkbox SVG is not rendered in Chrome. Replacing the "#" character with the percent encoded value "%23" seems to fix the problem. Most likely the same problem as this question and answer on Stack Overflow: https://stackoverflow.com/a/30733736
nelsonic
approved these changes
Dec 8, 2019
There was a problem hiding this comment.
Confirmed the checkbox item does not display in Chrome 78 on Mac: https://evancz.github.io/elm-todomvc
With @coryk135's fix on localhost we see the checkbox:
✅
ZimbiX
approved these changes
Jan 18, 2020
|
Actually, I hadn't seen the note at this link from the other PR. Maybe IE/Edge do require the whole thing to be URL encoded. |
ZimbiX
approved these changes
Jan 18, 2020
There was a problem hiding this comment.
Testing with Sauce Labs:
The SVG checkmark works in current Edge. It doesn't show in legacy Edge (Trident-based rather than Chromium) or IE 11, but it does fall back to the system one. Odd how legacy Edge has the top one rotated xP Anyway, supporting legacy browsers sucks, so it looks good enough to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The todo-list checkbox SVG is not rendered in Chrome. Replacing the "#" character with the percent encoded value "%23" seems to fix the problem.
Most likely the same problem as this question and answer on Stack Overflow: https://stackoverflow.com/a/30733736