-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: item media annotation search #2456
base: master
Are you sure you want to change the base?
Conversation
JIRA ticket: EC-6945 |
Preview deployment: https://pr-2456.portal-js.dev.eanadev.org/ |
So that it is not picked up by the main search.
Quality Gate passedIssues Measures |
return { fetchPresentation, hasAnnotations, page, resource, resourceCount, setPage, setPresentationFromWebResources }; | ||
|
||
return { | ||
activeAnnotation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being passed as a prop to MediaImageViewer. Wouldn't it make more sense to have the viewer use it from the composable directly? Or is there some reactivity that comes from passing it in as a prop?
page, | ||
pageForAnnotationTarget, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't actually seem to be used in the Presentation at this point.
resource, | ||
resourceCount, | ||
selectAnnotation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also not used here anymore since it's moved to the annotationList.
Composables:
itemMediaPresentation
:activeTab
:Components:
ItemHero
:ItemMediaPresentation
:useItemMediaPresentation
composableItemPreviewCard
:ItemPreviewCardGroup
:ItemPreviewCard
, plus default to the annotation search tab via the hash if one is presentItemMediaSidebar
:activeTab
composableMediaAnnotationList
:useItemMediaPresentation
composable, not by emitting itquery
prop which takes a search term, and if present searches annotations rather than fetching those for the current page/canvasMediaAnnotationSearch
:MediaAnnotationList
with the search query passed to it