Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude table #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

grandegoiania
Copy link

These filters was useful to me
include-table = include table(s) with regex
exclude-table = exclude table(s) with regex
exclude-column = exclude column(s) of all tables with regex
exclude-table-column = exclude the combination of table and column with json array

@eulerto
Copy link
Owner

eulerto commented Aug 25, 2020

You provided 3 features in the same PR.

  1. filter table;
  2. filter table column;
  3. filter table + column.

Please submit one PR per feature. It is easier to review and merge it. Item 1 has been already in my radar, please create a PR with it. Item 2 and 3 are the same feature. IMO the syntax should be:

include-table-column = '*.columna, table1.*, table2.columnb'
exclude-table-column = 'table3.columnc, *.columnd'

@grandegoiania
Copy link
Author

I will separate the features, but let me explain my idea (what I needed):
1- table: include or exclude some tables (forgot to tie with schema)
2- column: exclude some columns that matches (column_name regex) on all tables
3- table-column: exclude a column of a specific table, not all columns with that name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants