fix pylint

euhoro · Jun 19, 2024 · 87e8123 · 87e8123
1 parent ec95877
commit 87e8123
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 72 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,7 @@ jobs:
         pip install -r requirements_dev.txt
     - name: Lint with Pylint
       run: |
-        pylint app main.py redis_inventory_service.py json_inventory_service.py atm_service.py tests
+        pylint main.py atm_repository_redis.py atm_repository_json_file.py atm_service.py tests
     - name: Format with Black
       run: |
         black --check .

diff --git a/.pylintrc b/.pylintrc
@@ -5,7 +5,7 @@ ignore=tests
 max-line-length=88
 
 [MESSAGES CONTROL]
-disable=C0114,C0115,C0116
+disable=C0114,C0115,C0116, C0301,C0415,W0718,W0612,R1710,W0150,R0913,W1514,R0912,C0411,C0304,R1705,W0134
 
 [REPORTS]
 output-format=colorized
diff --git a/atm_service_json_file.py → atm_repository_json_file.py b/atm_service_json_file.py → atm_repository_json_file.py
@@ -1,7 +1,4 @@
-import fcntl
 import json
-import os
-import time
 
 from common import Inventory, InventoryService
 

diff --git a/atm_service_redis.py → atm_repository_redis.py b/atm_service_redis.py → atm_repository_redis.py
diff --git a/atm_repository_sqllite.py b/atm_repository_sqllite.py
diff --git a/atm_service.py b/atm_service.py
@@ -1,7 +1,7 @@
 import os
 import time
 
-from atm_service_redis import RedisInventoryService
+from atm_repository_redis import RedisInventoryService
 from common import Inventory
 
 MAX_AMOUNT = 2000
@@ -28,7 +28,8 @@
 ERR_INSUFFICIENT_FUNDS = "Insufficient funds. Max available amount:"
 
 SETTINGS_MODE = os.getenv("SETTINGS_MODE", "redis")
-REDIS_HOST = os.getenv("REDIS_HOST", "127.0.0.1")  # Default to 127.0.0.1 for local development
+REDIS_HOST = os.getenv("REDIS_HOST", "127.0.0.1")
+# Default to 127.0.0.1 for local development
 
 
 def get_db_service():
@@ -38,7 +39,7 @@ def get_db_service():
         inventory_service = RedisInventoryService(
             redis.StrictRedis(host=REDIS_HOST, port=6379, db=0))
     else:
-        from atm_service_json_file import JSONFileInventoryService
+        from atm_repository_json_file import JSONFileInventoryService
         inventory_service = JSONFileInventoryService()
 
     return inventory_service