Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-248 Change current path after adding a new system #5701

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 22, 2025

Description Of Changes

After creating a new system, update the url to the new system's edit url.

Code Changes

  • Add router.push after system creation

Steps to Confirm

  1. In admin-ui, go to Add Systems > Add a system
  2. Enter a system name
  3. Scroll to the bottom and click Save
  4. Check that the url has change to this format systems/configure/{newSystemId}
  5. Reload the page and check that it loads the edit page for that system

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 6:42pm

Copy link

cypress bot commented Jan 22, 2025

fides    Run #11939

Run Properties:  status check passed Passed #11939  •  git commit e2ef770fcb ℹ️: Merge ac2881f916967373a9a7c04723ab8ab2be2c9597 into a51da8fc111d2b2dad6dcd48e455...
Project fides
Branch Review refs/pull/5701/merge
Run status status check passed Passed #11939
Run duration 00m 47s
Commit git commit e2ef770fcb ℹ️: Merge ac2881f916967373a9a7c04723ab8ab2be2c9597 into a51da8fc111d2b2dad6dcd48e455...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera requested a review from galvana January 27, 2025 16:10
@lucanovera
Copy link
Contributor Author

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this long-standing quirk!

@lucanovera lucanovera merged commit a5f3b49 into main Jan 27, 2025
20 checks passed
@lucanovera lucanovera deleted the LA-248-Refreshing-after-creating-a-new-System-redirects-to-ANOTHER-new-system branch January 27, 2025 18:55
Copy link

cypress bot commented Jan 27, 2025

fides    Run #11942

Run Properties:  status check passed Passed #11942  •  git commit a5f3b49942: LA-248 Change current path after adding a new system (#5701)
Project fides
Branch Review main
Run status status check passed Passed #11942
Run duration 00m 47s
Commit git commit a5f3b49942: LA-248 Change current path after adding a new system (#5701)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants