-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LA-248 Change current path after adding a new system #5701
Merged
lucanovera
merged 3 commits into
main
from
LA-248-Refreshing-after-creating-a-new-System-redirects-to-ANOTHER-new-system
Jan 27, 2025
Merged
LA-248 Change current path after adding a new system #5701
lucanovera
merged 3 commits into
main
from
LA-248-Refreshing-after-creating-a-new-System-redirects-to-ANOTHER-new-system
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides Run #11939
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5701/merge
|
Run status |
Passed #11939
|
Run duration | 00m 47s |
Commit |
e2ef770fcb ℹ️: Merge ac2881f916967373a9a7c04723ab8ab2be2c9597 into a51da8fc111d2b2dad6dcd48e455...
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
@galvana Preview link for testing: https://fides-plus-nightly-git-la-248-refreshing-after-cr-f4c23c-ethyca.vercel.app/ |
galvana
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this long-standing quirk!
…m-redirects-to-ANOTHER-new-system
lucanovera
deleted the
LA-248-Refreshing-after-creating-a-new-System-redirects-to-ANOTHER-new-system
branch
January 27, 2025 18:55
fides Run #11942
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11942
|
Run duration | 00m 47s |
Commit |
a5f3b49942: LA-248 Change current path after adding a new system (#5701)
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
After creating a new system, update the url to the new system's edit url.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works