Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-219 Update updated_at field of cache entry even if value doesn't change #5669

Closed
wants to merge 2 commits into from

Conversation

erosselli
Copy link
Contributor

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:11pm

@erosselli erosselli closed this Jan 14, 2025
Copy link

cypress bot commented Jan 14, 2025

fides    Run #11750

Run Properties:  status check passed Passed #11750  •  git commit 1f812a9afd ℹ️: Merge ebcc49fff10d5c82f2076b35ed7be82d31a6f1d7 into de209feb31ce2619c9db608d41fa...
Project fides
Branch Review refs/pull/5669/merge
Run status status check passed Passed #11750
Run duration 00m 53s
Commit git commit 1f812a9afd ℹ️: Merge ebcc49fff10d5c82f2076b35ed7be82d31a6f1d7 into de209feb31ce2619c9db608d41fa...
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (de209fe) to head (ebcc49f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5669   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         388      388           
  Lines       24012    24014    +2     
  Branches     2593     2593           
=======================================
+ Hits        20926    20928    +2     
  Misses       2525     2525           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant