Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening new session to complete task activities #5667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jan 14, 2025

Closes LA-108

Description Of Changes

This PR is to commit the changes done as part of testing in #5547

Code Changes

  • Opens a new session to finalize the task activities for the run_access_node, run_erasure_node, and run_consent_node

Steps to Confirm

  1. No new functionality, this just makes it so that long running DSR tasks can complete their finalizing activities, even after running a long query or request.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Jan 14, 2025 1:53am

@galvana galvana mentioned this pull request Jan 14, 2025
13 tasks
Copy link

cypress bot commented Jan 14, 2025

fides    Run #11735

Run Properties:  status check passed Passed #11735  •  git commit 4c49002868 ℹ️: Merge c5eb962aa4d5273734b885bcb1508dd18872d98b into de209feb31ce2619c9db608d41fa...
Project fides
Branch Review refs/pull/5667/merge
Run status status check passed Passed #11735
Run duration 00m 51s
Commit git commit 4c49002868 ℹ️: Merge c5eb962aa4d5273734b885bcb1508dd18872d98b into de209feb31ce2619c9db608d41fa...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (de209fe) to head (c5eb962).

Files with missing lines Patch % Lines
src/fides/api/task/execute_request_tasks.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5667   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         388      388           
  Lines       24012    24020    +8     
  Branches     2593     2593           
=======================================
+ Hits        20926    20933    +7     
- Misses       2525     2526    +1     
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during screenshare CR session. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants