Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to resubmit DSRs #5658

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Adding ability to resubmit DSRs #5658

wants to merge 12 commits into from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jan 11, 2025

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 5:37am

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Jan 11, 2025
@cypress Cypress
Copy link

cypress bot commented Jan 11, 2025 •
edited
Loading

fides    Run #11708

Run Properties:  status check failed Failed #11708  •  git commit 49ac0f9e8b ℹ️: Merge d1948a86a07f90a4e49b7a06df488f0c1a4f3fcc into 1de84b5837eb68474c3325abbcf5...
Project fides
Branch Review refs/pull/5658/merge
Run status status check failed Failed #11708
Run duration 01m 05s
Commit git commit 49ac0f9e8b ℹ️: Merge d1948a86a07f90a4e49b7a06df488f0c1a4f3fcc into 1de84b5837eb68474c3325abbcf5...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@galvana