Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render 'Reclassify' button in overflow menu when applicable #5655

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Render 'Reclassify' button in overflow menu when applicable #5655

merged 9 commits into from
Jan 13, 2025

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jan 9, 2025 •
edited by gilluminate
Loading

Closes HJ-341

Description Of Changes

Screenshot 2025-01-09 at 03 28 57

Changes discovery item actions cell so "Reclassify" option renders in an overflow menu when both promote and mute actions are available, to keep from overloading the cell with 3 action buttons.

Steps to Confirm

  1. Run a monitor and classify the results
  2. View results in discovery table
  3. Results should have both "Confirm" and "Ignore" options and "Reclassify" option in kebab menu
  4. View a result without one of the other two actions (for example, subfields of a nested field which don't have the "Confirm" action)
  5. "Reclassify" should show up as an action button in the cell

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 3:35pm

@cypress Cypress
Copy link

cypress bot commented Jan 9, 2025 •
edited
Loading

fides    Run #11717

Run Properties:  status check passed Passed #11717  •  git commit 45274f3a02 ℹ️: Merge 7510c7b7287d50345557e9cff31041aedf401b9a into 73188c53f9479cd6dbd4f3637a4f...
Project fides
Branch Review refs/pull/5655/merge
Run status status check passed Passed #11717
Run duration 00m 50s
Commit git commit 45274f3a02 ℹ️: Merge 7510c7b7287d50345557e9cff31041aedf401b9a into 73188c53f9479cd6dbd4f3637a4f...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@jpople jpople requested a review from gilluminate January 10, 2025 15:32
gilluminate
gilluminate reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to these changes, I would suggest adding
meta: { width: "auto" }
to the Actions column definition so that the column just takes on the width of the buttons

...admin-ui/src/features/data-discovery-and-detection/tables/cells/DiscoveryItemActionsCell.tsx Outdated
<MenuItem
onClick={handleReclassify}
icon={<RepeatIcon />}
data-testid="action-Reclassify"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super duper nitpicky suggestion:

Suggested change
data-testid="action-Reclassify"
data-testid="action-reclassify"

gilluminate
gilluminate approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the clean up. Looks good

@jpople jpople merged commit 7ea4ad5 into main Jan 13, 2025
20 checks passed
@jpople jpople deleted the jpople/hj-341/reclassify-button-fix branch January 13, 2025 16:05
@cypress Cypress
Copy link

cypress bot commented Jan 13, 2025

fides    Run #11720

Run Properties:  status check failed Failed #11720  •  git commit 7ea4ad58d4: Render 'Reclassify' button in overflow menu when applicable (#5655)
Project fides
Branch Review main
Run status status check failed Failed #11720
Run duration 01m 05s
Commit git commit 7ea4ad58d4: Render 'Reclassify' button in overflow menu when applicable (#5655)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @gilluminate