Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust button sizes in table headers #5654

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Adjust button sizes in table headers #5654

merged 7 commits into from
Jan 15, 2025

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jan 9, 2025 •
edited by gilluminate
Loading

Closes HJ-109

Description Of Changes

Changes buttons located in table headers to be Ant's "middle" size instead of "small"; also alters button group spacing on a few of them for consistency.

Steps to Confirm

Verify that buttons in table headers in the following tables are the correct size:

  • Data map report
  • Request manager
  • Vendors
  • Notices
  • Experiences
  • Properties
  • Messaging
  • Custom fields
  • D&D monitors table in "Integrations" page
  • Discovery result "bulk action" buttons

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 4:54pm

@cypress Cypress
Copy link

cypress bot commented Jan 9, 2025 •
edited
Loading

fides    Run #11773

Run Properties:  status check passed Passed #11773  •  git commit 299f627a9c ℹ️: Merge 04d5ec8aa3864162dfe6f7b06f2cb57533e2ab46 into 31dcf581537828acfc6cb9628277...
Project fides
Branch Review refs/pull/5654/merge
Run status status check passed Passed #11773
Run duration 00m 40s
Commit git commit 299f627a9c ℹ️: Merge 04d5ec8aa3864162dfe6f7b06f2cb57533e2ab46 into 31dcf581537828acfc6cb9628277...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@jpople jpople requested a review from gilluminate January 10, 2025 15:32
gilluminate
gilluminate approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@jpople jpople merged commit a4f4aec into main Jan 15, 2025
20 checks passed
@jpople jpople deleted the jpople/hj-109/table-header-button-fix branch January 15, 2025 17:33
@cypress Cypress
Copy link

cypress bot commented Jan 15, 2025

fides    Run #11775

Run Properties:  status check passed Passed #11775  •  git commit a4f4aec1a4: Adjust button sizes in table headers (#5654)
Project fides
Branch Review main
Run status status check passed Passed #11775
Run duration 00m 59s
Commit git commit a4f4aec1a4: Adjust button sizes in table headers (#5654)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @gilluminate