-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saved report bug fixes #5649
Merged
Merged
Saved report bug fixes #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #11667
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5649/merge
|
Run status |
Passed #11667
|
Run duration | 00m 51s |
Commit |
c271d68abb ℹ️: Merge c05a7f7b66a7377e159a9235a5a9eebf96178c93 into b805c8c8d9f06578b49b4faaeab2...
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
This also affected the download report
gilluminate
force-pushed
the
gill/HJ-155/saved-report-reset-bug
branch
from
January 7, 2025 17:28
2610271
to
f0b988e
Compare
andres-torres-marroquin
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, looking forward to pull these changes into my current work.
fides Run #11668
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11668
|
Run duration | 00m 48s |
Commit |
2d9f1ef270: Saved report bug fixes (#5649)
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-357, HJ-155
Description Of Changes
tableinstance
columns, rather than the backend defined columns.Steps to Confirm
/reporting/datamap
.Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works