Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-352 - Fixes some fields that are not present on the CSV and they shouldn't be present on the web datamap report #5645

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Jan 6, 2025

Closes #HJ-352

Description Of Changes

Fixes some fields that are not present on the CSV and they shouldn't be present on the web datamap report

Code Changes

  • Updated frontend code to be aware of the deletion of some deprecated fields.

Steps to Confirm

  1. This requires https://github.com/ethyca/fidesplus/pull/1788 changes.
  2. On Datamap report:
  • DATA_SHARED_WITH_THIRD_PARTIES became data_shared_with_third_parties in the code.
  • Egress became Destination
  • Ingress became Source
  • Remove link_to_processor_contract
  • Remove system_dependencies
  • Remove third_country_safeguards
  • Check that the column order presented on a fresh browser is the same on the web and on the csv.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Sorry, something went wrong.

…houldn't be present on the web datamap report
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:07pm

Copy link

cypress bot commented Jan 6, 2025

fides    Run #11689

Run Properties:  status check failed Failed #11689  •  git commit 486afe080e ℹ️: Merge 2c3b8b6c22b8bb66064125dda7b2ccc4ddd10568 into a583252764b5507df81740882eba...
Project fides
Branch Review refs/pull/5645/merge
Run status status check failed Failed #11689
Run duration 01m 01s
Commit git commit 486afe080e ℹ️: Merge 2c3b8b6c22b8bb66064125dda7b2ccc4ddd10568 into a583252764b5507df81740882eba...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI Screenshots Video

@andres-torres-marroquin andres-torres-marroquin marked this pull request as ready for review January 6, 2025 19:17
@@ -24,7 +24,7 @@
"legal_address",
"cookie_refresh",
"data_security_practices",
"DATA_SHARED_WITH_THIRD_PARTIES",
"data_shared_with_third_parties",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong uppercase fixed

@@ -241,6 +241,9 @@ export const getDatamapReportColumns = ({
columnHelper.accessor((row) => row.data_shared_with_third_parties, {
id: COLUMN_IDS.DATA_SHARED_WITH_THIRD_PARTIES,
}),
columnHelper.accessor((row) => row.processes_special_category_data, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we include this field on the web report

@@ -364,9 +367,6 @@ export const getDatamapReportColumns = ({
columnHelper.accessor((row) => row.legitimate_interest_disclosure_url, {
id: COLUMN_IDS.LEGITIMATE_INTEREST_DISCLOSURE_URL,
}),
columnHelper.accessor((row) => row.link_to_processor_contract, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was deprecated, now it's gone

},
}),
columnHelper.accessor((row) => row.third_country_safeguards, {
id: COLUMN_IDS.THIRD_COUNTRY_SAFEGUARDS,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was deprecated, now it's gone

@@ -414,24 +414,6 @@ export const getDatamapReportColumns = ({
columnHelper.accessor((row) => row.special_category_legal_basis, {
id: COLUMN_IDS.SPECIAL_CATEGORY_LEGAL_BASIS,
}),
columnHelper.accessor((row) => row.system_dependencies, {
id: COLUMN_IDS.SYSTEM_DEPENDENCIES,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was deprecated, now it's gone

@@ -27,7 +27,7 @@ export enum COLUMN_IDS {
LEGAL_ADDRESS = "legal_address",
COOKIE_REFRESH = "cookie_refresh",
DATA_SECURITY_PRACTICES = "data_security_practices",
DATA_SHARED_WITH_THIRD_PARTIES = "DATA_SHARED_WITH_THIRD_PARTIES",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong letter casing for the field

@@ -115,4 +110,6 @@ export const DEFAULT_COLUMN_NAMES: Record<COLUMN_IDS, string> = {
[COLUMN_IDS.USES_COOKIES]: "Uses cookies",
[COLUMN_IDS.USES_NON_COOKIE_ACCESS]: "Uses non-cookie access",
[COLUMN_IDS.USES_PROFILING]: "Uses profiling",
[COLUMN_IDS.PROCESSES_SPECIAL_CATEGORY_DATA]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new field on web

@@ -104,8 +101,6 @@ export const DEFAULT_COLUMN_NAMES: Record<COLUMN_IDS, string> = {
[COLUMN_IDS.RETENTION_PERIOD]: "Retention period",
[COLUMN_IDS.SHARED_CATEGORIES]: "Shared categories",
[COLUMN_IDS.SPECIAL_CATEGORY_LEGAL_BASIS]: "Special category legal basis",
[COLUMN_IDS.SYSTEM_DEPENDENCIES]: "System dependencies",
[COLUMN_IDS.THIRD_COUNTRY_SAFEGUARDS]: "Third country safeguards",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was deprecated, now it's gone

@@ -104,8 +101,6 @@ export const DEFAULT_COLUMN_NAMES: Record<COLUMN_IDS, string> = {
[COLUMN_IDS.RETENTION_PERIOD]: "Retention period",
[COLUMN_IDS.SHARED_CATEGORIES]: "Shared categories",
[COLUMN_IDS.SPECIAL_CATEGORY_LEGAL_BASIS]: "Special category legal basis",
[COLUMN_IDS.SYSTEM_DEPENDENCIES]: "System dependencies",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was deprecated, now it's gone

[COLUMN_IDS.JOINT_CONTROLLER_INFO]: "Joint controller info",
[COLUMN_IDS.LEGAL_BASIS_FOR_PROFILING]: "Legal basis for profiling",
[COLUMN_IDS.LEGAL_BASIS_FOR_TRANSFERS]: "Legal basis for transfers",
[COLUMN_IDS.LEGITIMATE_INTEREST_DISCLOSURE_URL]:
"Legitimate interest disclosure URL",
[COLUMN_IDS.LINK_TO_PROCESSOR_CONTRACT]: "Link to processor contract",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field was deprecated, now it's gone

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes locally and they are working as expected

@andres-torres-marroquin andres-torres-marroquin merged commit 1de84b5 into main Jan 10, 2025
18 of 19 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-352 branch January 10, 2025 14:17
Copy link

cypress bot commented Jan 10, 2025

fides    Run #11690

Run Properties:  status check failed Failed #11690  •  git commit 1de84b5837: HJ-352 - Fixes some fields that are not present on the CSV and they shouldn't be...
Project fides
Branch Review main
Run status status check failed Failed #11690
Run duration 01m 01s
Commit git commit 1de84b5837: HJ-352 - Fixes some fields that are not present on the CSV and they shouldn't be...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants