Updating static checks #5637
Merged
Updating static checks #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5637/merge
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5637 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 388 388
Lines 24000 24000
Branches 2594 2594
=======================================
Hits 20914 20914
Misses 2525 2525
Partials 561 561 ☔ View full report in Codecov by Sentry. |
galvana
commented
Jan 6, 2025
src/fides/api/main.py
Outdated
| docker=in_docker_container(), | ||
| event=Event.server_start.value, | ||
| event_created_at=datetime.now(tz=timezone.utc), | ||
| docker=in_docker_container(), event=Event.server_start.value, event_created_at=datetime.now(tz=timezone.utc), |
There was a problem hiding this comment.
Intentionally misformatting this to trigger a CI failure
galvana
commented
Jan 6, 2025
noxfiles/ci_nox.py
Outdated
Comment on lines
104
to
110
| session.run(*command, success_codes=[0, 1]) | ||
| session.log( | ||
| "Note: This command was malformed so it's been failing to report complexity issues." | ||
| ) | ||
| session.log( | ||
| "Intentionally suppressing the error status code for now to slowly work through the issues." | ||
| ) |
There was a problem hiding this comment.
This is the only thing we didn't discuss on Slack, let me know your thoughts on this one
There was a problem hiding this comment.
sure! looks good to me. could be a session.warn maybe, but perhaps that's a bit too noisy? i'm fine either way
adamsachs
approved these changes
Jan 7, 2025
noxfiles/ci_nox.py
Outdated
Comment on lines
104
to
110
| session.run(*command, success_codes=[0, 1]) | ||
| session.log( | ||
| "Note: This command was malformed so it's been failing to report complexity issues." | ||
| ) | ||
| session.log( | ||
| "Intentionally suppressing the error status code for now to slowly work through the issues." | ||
| ) |
There was a problem hiding this comment.
sure! looks good to me. could be a session.warn maybe, but perhaps that's a bit too noisy? i'm fine either way
Co-authored-by: Adam Sachs <[email protected]>
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 57s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
maindowngrade()migration is correct and works