Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting up query config files and tests #5591

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 10, 2024

Description Of Changes

This change is done as part of #5575. I broke it out into a separate PR so it's easier to see the changes done to the query config files.

Code Changes

  • Splitting out different query configs into their own files

Steps to Confirm

  1. Tests should pass, this doesn't change any functionality

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 5:56pm

Copy link

cypress bot commented Dec 10, 2024

fides    Run #11730

Run Properties:  status check passed Passed #11730  •  git commit dc51554864 ℹ️: Merge 82cb4e946e61ae000b57050598f65bf4ead932a1 into 83cb612e4bc7f1fe424cab8a0a54...
Project fides
Branch Review refs/pull/5591/merge
Run status status check passed Passed #11730
Run duration 00m 39s
Commit git commit dc51554864 ℹ️: Merge 82cb4e946e61ae000b57050598f65bf4ead932a1 into 83cb612e4bc7f1fe424cab8a0a54...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (7ea4ad5) to head (8e7dd9d).

Files with missing lines Patch % Lines
.../connectors/query_configs/bigquery_query_config.py 0.00% 8 Missing ⚠️
...connectors/query_configs/snowflake_query_config.py 33.33% 2 Missing ⚠️
...fides/api/service/connectors/bigquery_connector.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5591      +/-   ##
==========================================
+ Coverage   87.13%   87.14%   +0.01%     
==========================================
  Files         388      388              
  Lines       24000    24012      +12     
  Branches     2594     2593       -1     
==========================================
+ Hits        20913    20926      +13     
  Misses       2525     2525              
+ Partials      562      561       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana merged commit de209fe into main Jan 13, 2025
17 checks passed
@galvana galvana deleted the split-query-config-files branch January 13, 2025 18:02
Copy link

cypress bot commented Jan 13, 2025

fides    Run #11731

Run Properties:  status check passed Passed #11731  •  git commit de209feb31: Splitting up query config files and tests (#5591)
Project fides
Branch Review main
Run status status check passed Passed #11731
Run duration 01m 00s
Commit git commit de209feb31: Splitting up query config files and tests (#5591)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants