-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting up query config files and tests #5591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #11730
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5591/merge
|
Run status |
Passed #11730
|
Run duration | 00m 39s |
Commit |
dc51554864 ℹ️: Merge 82cb4e946e61ae000b57050598f65bf4ead932a1 into 83cb612e4bc7f1fe424cab8a0a54...
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
==========================================
+ Coverage 87.13% 87.14% +0.01%
==========================================
Files 388 388
Lines 24000 24012 +12
Branches 2594 2593 -1
==========================================
+ Hits 20913 20926 +13
Misses 2525 2525
+ Partials 562 561 -1 ☔ View full report in Codecov by Sentry. |
eastandwestwind
approved these changes
Jan 13, 2025
fides Run #11731
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11731
|
Run duration | 01m 00s |
Commit |
de209feb31: Splitting up query config files and tests (#5591)
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This change is done as part of #5575. I broke it out into a separate PR so it's easier to see the changes done to the query config files.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works