versioning support for Fides #5435
Open
+96
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gilluminate
force-pushed
the
gill/versioning
branch
from
e7f7e6b to
0c15dda
Compare
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5435/merge
|
| Run status |
|
| Run duration | 00m 48s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
NevilleS
requested changes
Oct 30, 2024
| @@ -111,6 +113,7 @@ export default async function handler( | |||
| // Load the configured consent options (data uses, defaults, etc.) from environment | |||
| const environment = await loadPrivacyCenterEnvironment(); | |||
| const serverSettings = await loadServerSettings(); | |||
| const { version } = npmPackage; | |||
There was a problem hiding this comment.
To suggest a bit of scope creep - this is technically the privacy-center version (not fides-js). We could also expose the privacy-center version through a simple /health API route as well, which would be helpful.
There was a problem hiding this comment.
Good point and suggestion
There was a problem hiding this comment.
ok, got this working at http://localhost:3001/api/health
gilluminate
force-pushed
the
gill/versioning
branch
from
daf5fb3 to
611f4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-30
Description Of Changes
window.Fidesobject/api/healthendpoint to the Privacy Center with FidesJS and Privacy Center versions as response, similar to other../healthendpoints.Steps to Confirm
turbo version -- 2.48.1from the/clientsdirectoryFides.versionfrom the console log2.48.1is returnedhttp://localhost:3001/api/healthand notice that2.48.1is returnedPre-Merge Checklist
CHANGELOG.md