Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text replacement pattern for Vendor Count #5217

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Aug 20, 2024

Description Of Changes

Updates work done in #5210 to now use {{ VENDOR_COUNT_LINK }} instead. This will align better with other backend templates and avoid ESLint complaints about using the ${...} format for non-template strings.

Code Changes

  • replaces ${VENDOR_COUNT_LINK} support with {{ VENDOR_COUNT_LINK }} instead.

Steps to Confirm

(these steps have been updated as part of #5223. Use those steps instead)

Pre-Merge Checklist

  • All CI Pipelines Succeeded

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Aug 20, 2024 3:52pm

Copy link

cypress bot commented Aug 20, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 5f96933c2d ℹ️
Started Aug 20, 2024 4:04 PM
Ended Aug 20, 2024 4:05 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@gilluminate gilluminate merged commit 4abdffd into main Aug 20, 2024
13 checks passed
@gilluminate gilluminate deleted the update-template-pattern branch August 20, 2024 16:17
Copy link

cypress bot commented Aug 20, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 4abdffd
Started Aug 20, 2024 4:29 PM
Ended Aug 20, 2024 4:30 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants