Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump integration versions for changes in #5054 #5207

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SteveDMurphy
Copy link
Contributor

Closes FIDES-1154

Description Of Changes

This was found when troubleshooting an error message from a user:

Custom SaaS override 'appsflyer_user_read' does not exist. Valid custom SaaS override classes for SaaSRequestType SaaSRequestType.READ are [firebase_auth_user_access, iterate_company_read, marigold_engage_user_read, oracle_responsys_profile_list_recipients_read, oracle_responsys_profile_extension_recipients_read]

It appears the custom overrides were removed as part of #5054 but the version were not bumped. Any deployed integration that uses this Fides version will continue to look for the override

Code Changes

  • Bump the impacted integrations versions

Steps to Confirm

  • We can do this manually today and restart the service, so it can cover the gap in the meantime

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Aug 16, 2024 9:28am

@SteveDMurphy SteveDMurphy force-pushed the SteveDMurphy-fides-1148-integration-bumps branch from c5c5a6c to 0aa03a3 Compare August 16, 2024 09:28
Copy link

cypress bot commented Aug 16, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 37ef3715d4 ℹ️
Started Aug 16, 2024 9:41 AM
Ended Aug 16, 2024 9:41 AM
Duration 00:34 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (d739aad) to head (0aa03a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5207      +/-   ##
==========================================
- Coverage   86.56%   86.55%   -0.01%     
==========================================
  Files         362      362              
  Lines       22741    22741              
  Branches     3026     3026              
==========================================
- Hits        19685    19684       -1     
  Misses       2511     2511              
- Partials      545      546       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant