Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for consent signal processing #5200
Updates for consent signal processing #5200
Changes from all commits
91e635d
224b5dc
7c8cda0
9521550
4eca107
1b0f595
5753e94
aa1ad40
146df41
9066caf
ddd554f
296fd54
b6dec0a
d0adc40
a967723
e22f113
a20d2e4
fd674ed
0b7bb0f
27e8774
1d69b06
22176f7
7d95255
03a389a
227ddbd
1301015
837e347
f0b86b3
13a0893
2593fe3
1aef805
384d8d5
2273cc4
f58ed0c
2c9c8cb
30a18d5
6de8e72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot happening in
run_consent_request
now, a followup ticket could try to break some of this logic into separate functions -There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! I thought about doing it during this pass but a follow up ticket sound better https://ethyca.atlassian.net/browse/PROD-2659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems net new - if I'm following this will now cause an exception to be raised on L826 when before it was just ignored? Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously set
fired = False
at the start, and iffired
remainedFalse
by the end, we assumed data was missing and raised aSkippingConsentPropagation
exception with the message "Missing needed values to propagate request". Now, we're setting this explicitly if we get aValueError
when building a consent request andskip_missing_param_values
is set toTrue
Same behavior as before but now it's more explicit