Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2352 addendum: make mypy happy #5195

Merged
merged 4 commits into from
Aug 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/fides/api/models/detection_discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
from enum import Enum
from typing import Any, Dict, Iterable, List, Optional, Type

from sqlalchemy import ARRAY, Boolean, Column, DateTime, ForeignKey, String, select
from sqlalchemy import ARRAY, Boolean, Column, DateTime, ForeignKey, String
from sqlalchemy.dialects.postgresql import JSONB
from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.ext.mutable import MutableDict
from sqlalchemy.future import select
from sqlalchemy.orm import Session, relationship

from fides.api.db.base_class import Base, FidesBase
Expand Down Expand Up @@ -287,7 +288,7 @@ def get_urn_list(cls, db: Session, urns: Iterable[str]) -> Iterable[StagedResour
"""
Utility to retrieve all staged resources with the given URNs
"""
results = db.execute(select(StagedResource).where(StagedResource.urn.in_(urns))) # type: ignore
results = db.execute(select(StagedResource).where(StagedResource.urn.in_(urns)))
return results.scalars().all()

@classmethod
Expand All @@ -298,7 +299,7 @@ async def get_urn_async(
Utility to retrieve the staged resource with the given URN using an async session
"""
results = await db.execute(
select(StagedResource).where(StagedResource.urn == urn) # type: ignore
select(StagedResource).where(StagedResource.urn == urn)
)
return results.scalars().first()

Expand Down