Hiding privacy request source data behind plus flag

ethyca · Aug 16, 2024 · 9066caf · 9066caf
1 parent 146df41
commit 9066caf
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 14 deletions.
diff --git a/clients/admin-ui/src/features/privacy-requests/RequestDetails.tsx b/clients/admin-ui/src/features/privacy-requests/RequestDetails.tsx
@@ -11,6 +11,7 @@ import {
 
 import ClipboardButton from "~/features/common/ClipboardButton";
 import DaysLeftTag from "~/features/common/DaysLeftTag";
+import { useFeatures } from "~/features/common/features";
 import RequestStatusBadge from "~/features/common/RequestStatusBadge";
 import RequestType from "~/features/common/RequestType";
 import { PrivacyRequestEntity } from "~/features/privacy-requests/types";
@@ -25,6 +26,7 @@ type RequestDetailsProps = {
 };
 
 const RequestDetails = ({ subjectRequest }: RequestDetailsProps) => {
+  const { plus: hasPlus } = useFeatures();
   const { id, status, policy } = subjectRequest;
 
   return (
@@ -55,7 +57,7 @@ const RequestDetails = ({ subjectRequest }: RequestDetailsProps) => {
         </Text>
         <ClipboardButton copyText={id} />
       </Flex>
-      {subjectRequest.source && (
+      {hasPlus && subjectRequest.source && (
         <Flex>
           <Text mb={4} mr={2} fontSize="sm" color="gray.900" fontWeight="500">
             Source:

diff --git a/clients/admin-ui/src/features/privacy-requests/RequestTable.tsx b/clients/admin-ui/src/features/privacy-requests/RequestTable.tsx
@@ -20,6 +20,7 @@ import { useMemo, useState } from "react";
 import { useDispatch, useSelector } from "react-redux";
 
 import { selectToken } from "~/features/auth";
+import { useFeatures } from "~/features/common/features";
 import { DownloadLightIcon } from "~/features/common/Icon";
 import {
   FidesTableV2,
@@ -43,6 +44,7 @@ import { RequestTableFilterModal } from "~/features/privacy-requests/RequestTabl
 import { PrivacyRequestEntity } from "~/features/privacy-requests/types";
 
 export const RequestTable = ({ ...props }: BoxProps): JSX.Element => {
+  const { plus: hasPlus } = useFeatures();
   const [requestIdFilter, setRequestIdFilter] = useState<string>();
   const [revealPII, setRevealPII] = useState<boolean>(false);
   const filters = useSelector(selectPrivacyRequestFilters);
@@ -124,7 +126,10 @@ export const RequestTable = ({ ...props }: BoxProps): JSX.Element => {
   const tableInstance = useReactTable<PrivacyRequestEntity>({
     getCoreRowModel: getCoreRowModel(),
     data: requests,
-    columns: useMemo(() => getRequestTableColumns(revealPII), [revealPII]),
+    columns: useMemo(
+      () => getRequestTableColumns(revealPII, hasPlus),
+      [revealPII, hasPlus],
+    ),
     getRowId: (row) => `${row.status}-${row.id}`,
     manualPagination: true,
   });

diff --git a/clients/admin-ui/src/features/privacy-requests/RequestTableColumns.tsx b/clients/admin-ui/src/features/privacy-requests/RequestTableColumns.tsx
@@ -30,7 +30,7 @@ enum COLUMN_IDS {
 
 const columnHelper = createColumnHelper<PrivacyRequestEntity>();
 
-export const getRequestTableColumns = (revealPII = false) => [
+export const getRequestTableColumns = (revealPII = false, hasPlus = false) => [
   columnHelper.accessor((row) => row.status, {
     id: COLUMN_IDS.STATUS,
     cell: ({ getValue }) => <RequestStatusBadgeCell value={getValue()} />,
@@ -47,17 +47,21 @@ export const getRequestTableColumns = (revealPII = false) => [
     ),
     header: (props) => <DefaultHeaderCell value="Days left" {...props} />,
   }),
-  columnHelper.accessor((row) => row.source, {
-    id: COLUMN_IDS.SOURCE,
-    cell: (props) =>
-      props.getValue() ? (
-        <BadgeCell value={props.getValue()!} />
-      ) : (
-        <DefaultCell value={undefined} />
-      ),
-    header: (props) => <DefaultHeaderCell value="Source" {...props} />,
-    enableSorting: false,
-  }),
+  ...(hasPlus
+    ? [
+        columnHelper.accessor((row) => row.source, {
+          id: COLUMN_IDS.SOURCE,
+          cell: (props) =>
+            props.getValue() ? (
+              <BadgeCell value={props.getValue()!} />
+            ) : (
+              <DefaultCell value={undefined} />
+            ),
+          header: (props) => <DefaultHeaderCell value="Source" {...props} />,
+          enableSorting: false,
+        }),
+      ]
+    : []),
   columnHelper.accessor((row) => row.policy.rules, {
     id: COLUMN_IDS.REQUEST_TYPE,
     cell: ({ getValue }) => <RequestActionTypeCell value={getValue()} />,