fix linting issues, especially with Cypress directories (#5189)

.vscode/settings.json

@@ -6,9 +6,11 @@
   "eslint.workingDirectories": [
     "./clients",
     "./clients/admin-ui",
+    "./clients/admin-ui/cypress",
     "./clients/fides-js",
     "./clients/fidesui",
     "./clients/privacy-center",
+    "./clients/privacy-center/cypress",
     "./clients/cypress-e2e",
     "./clients/sample-app"
   ],

clients/admin-ui/.eslintignore

@@ -5,3 +5,4 @@ public/**/*.js
 next.config.js
 jest.config.js
 cypress.config.ts
+.eslintrc*

clients/admin-ui/cypress.config.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-extraneous-dependencies */
 import { defineConfig } from "cypress";
 
 export default defineConfig({

clients/admin-ui/cypress/.eslintignore

@@ -0,0 +1 @@
+.eslintrc.*

clients/admin-ui/cypress/.eslintrc.cjs

@@ -1,13 +1,23 @@
 module.exports = {
-  extends: ["plugin:cypress/recommended"],
-  plugins: ["no-only-tests", "cypress"],
+  extends: ["plugin:cypress/recommended", "plugin:prettier/recommended"],
+  plugins: [
+    "no-only-tests",
+    "cypress",
+    "simple-import-sort",
+    "@typescript-eslint",
+    "import",
+  ],
   root: true,
+  parser: "@typescript-eslint/parser",
   parserOptions: {
     project: "./tsconfig.json",
     tsconfigRootDir: __dirname,
   },
   rules: {
     "no-only-tests/no-only-tests": "error",
     "cypress/unsafe-to-chain-command": "off",
+    "simple-import-sort/imports": "error",
+    "simple-import-sort/exports": "error",
+    "prettier/prettier": "warn",
   },
 };

clients/admin-ui/cypress/tsconfig.json

@@ -9,5 +9,5 @@
       "~/*": ["src/*"]
     }
   },
-  "include": ["**/*.ts", "**/*.tsx", "../cypress.config.ts"]
+  "include": ["**/*.ts", "**/*.tsx"]
 }

clients/admin-ui/tsconfig.json

@@ -42,10 +42,5 @@
     "**/*.d.ts",
     ".next/types/**/*.ts"
   ],
-  "exclude": [
-    "node_modules",
-    "cypress/**/*.ts",
-    "cypress/**/*.tsx",
-    "cypress.config.ts"
-  ]
+  "exclude": ["node_modules", "cypress", "./cypress.config.ts"]
 }

clients/cypress-e2e/.eslintignore

@@ -0,0 +1 @@
+.eslintrc.*

clients/cypress-e2e/.eslintrc.cjs

@@ -0,0 +1,14 @@
+module.exports = {
+  extends: ["plugin:cypress/recommended"],
+  plugins: ["no-only-tests", "cypress"],
+  root: true,
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    project: "./tsconfig.json",
+    tsconfigRootDir: __dirname,
+  },
+  rules: {
+    "no-only-tests/no-only-tests": "error",
+    "cypress/unsafe-to-chain-command": "off",
+  },
+};

clients/cypress-e2e/cypress/support/commands.ts

@@ -36,7 +36,6 @@ declare global {
        * @example cy.getToggle().should("be.checked");
        */
       getToggle(
-        value?: string,
         options?: Partial<
           Cypress.Loggable &
             Cypress.Timeoutable &