Skip to content

Commit

Permalink
fix: ignore 404s on delete endpoints
Browse files Browse the repository at this point in the history
this prevents race conditions when duplicate requests are submitted or the responsys user is deleted outside of Fides
  • Loading branch information
RobertKeyser committed Aug 15, 2024
1 parent b1544ff commit 466648e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion data/saas/config/oracle_responsys_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ saas_config:
name: Oracle Responsys
type: oracle_responsys
description: A sample schema representing the Oracle Responsys connector for Fides
version: 0.0.2
version: 0.0.3

connector_params:
- name: domain
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ def oracle_responsys_profile_list_recipients_delete(
SaaSRequestParams(
method=HTTPMethod.DELETE,
path=f"/rest/api/v1.3/lists/{list_id}/members/{responsys_id}",
)
),
[404],
)

rows_deleted += 1
Expand Down

0 comments on commit 466648e

Please sign in to comment.