Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fides): Add custom secrets for all fides containers. #78

Merged
merged 2 commits into from
Aug 9, 2024
Merged

feat(fides): Add custom secrets for all fides containers. #78

merged 2 commits into from
Aug 9, 2024

Conversation

mikaeld
Copy link
Contributor

@mikaeld mikaeld commented Aug 9, 2024

Description of Changes

This enables loading secrets in environment variables via valueFrom secretKeyRef using secret name and key.

Closes ###

Pre-merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Increment Applicable Chart Versions
  • Relevant Follow-Up Issues Created
  • Update the Fides chart CHANGELOG.md
  • Update the Fides-minimal chart CHANGELOG.md

@mikaeld mikaeld requested a review from a team as a code owner August 9, 2024 12:48
@RobertKeyser
Copy link
Contributor

LGTM! Thanks for your contribution!

@RobertKeyser RobertKeyser merged commit a2965d4 into ethyca:main Aug 9, 2024
1 of 2 checks passed
@mikaeld mikaeld deleted the feat/add-custom-fides-secrets branch August 9, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKeyser RobertKeyser RobertKeyser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaeld @RobertKeyser