Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla Service Annotations #76

Merged

Conversation

the-chronomancer
Copy link
Contributor

This adds annotations to the Values.fides.service object, allowing ingress annotations when using GKE. This is helpful for situations when you need to leverage:

annotations:  
  cloud.google.com/neg: '{"ingress": true}'

And other annotations in your environments.

This adds the following to the fides-service.yaml in both fides-minimal/templates/fides/ and fides/templates/fides/:

{{- with .Values.fides.service.annotations }}
annotations: {{- toYaml . | nindent 4 }}
{{- end }}

Pre-merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Increment Applicable Chart Versions
  • Relevant Follow-Up Issues Created
  • Update the Fides chart CHANGELOG.md
  • Update the Fides-minimal chart CHANGELOG.md

@the-chronomancer the-chronomancer requested a review from a team as a code owner May 22, 2024 17:31
@RobertKeyser RobertKeyser self-assigned this May 22, 2024
@RobertKeyser
Copy link
Contributor

Thank you for your contributions!

@RobertKeyser RobertKeyser merged commit f95f2d5 into ethyca:main May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants