fix: don't truncate names too arbitrarily #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I am not entirely sure what constraints #96 was navigating, so take the proposal with a grain of salt ! |
sigma
force-pushed
the
sigma/fix-label
branch
from
5ebb4e0 to
27a9452
Compare
sigma
force-pushed
the
sigma/fix-label
branch
from
27a9452 to
98e4a9a
Compare
The problem with selecting the last 63 characters of the image name for a k8s label is that there's no guarantee that the result will respect the other contraints. In particular, us-docker.pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101411.4-rc.4 yields .pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101411.4-rc.4 which is invalid because it starts with a dot. So the net outcome is that valid images fail to deploy because of an invalid attached label. This change select the longest prefix available while breaking only at / So for the image above, the label would be oplabs-tools-artifacts/images/op-geth:v1.101411.4-rc.4
sigma
force-pushed
the
sigma/fix-label
branch
from
98e4a9a to
616bf6f
Compare
zhwrd
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with selecting the last 63 characters of the image name
for a k8s label is that there's no guarantee that the result will
respect the other contraints.
In particular,
us-docker.pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101411.4-rc.4
yields .pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101411.4-rc.4
which is invalid because it starts with a dot.
So the net outcome is that valid images fail to deploy because of an
invalid attached label.
This change select the longest prefix available while breaking only at /
So for the image above, the label would be
oplabs-tools-artifacts/images/op-geth:v1.101411.4-rc.4