-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(prysm): update default build method to go (forces bazel for minimal) #215
Open
mattevans
wants to merge
3
commits into
master
Choose a base branch
from
chore/default-prysm-build-go
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasbusa
approved these changes
Dec 6, 2024
Lets hold this off actually till we got the minimal build thing working #217 |
* master: autobuild grandine mekong branch feat: expose full commit hash to build scripts (#216)
|
mattevans
changed the title
build(prysm): update default build method to go
build(prysm): update default build method to go (forces bazel for minimal)
Dec 12, 2024
we good to merge this? |
Yeah, seems ok? Ran another test this morning to be sure. https://github.com/ethpandaops/eth-client-docker-image-builder/actions/runs/12342543936 beacon (go)Example kurtosis cfg.participants:
- el_type: geth
cl_type: lighthouse
- cl_type: prysm
cl_image: ethpandaops/prysm-beacon-chain:check-defaults-linux-arm64-11aa51e # beacon, go build. Booted fine, started syncing.
beacon-minimal (bazel)Example kurtosis cfg.participants:
- el_type: geth
cl_type: lighthouse
- cl_type: prysm
cl_image: ethpandaops/prysm-beacon-chain:check-defaults-minimal-linux-arm64-11aa51e # beacon-minimal, bazel build.
network_params:
preset: minimal Booted fine, started syncing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.