Fix some failing hive tests in the devp2p/snap sync test suite #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -195,10 +188,10 @@ function parseGethParams(json: any) { | |||
| } | |||
|
|
|||
| if (config.terminalTotalDifficulty !== undefined) { | |||
There was a problem hiding this comment.
I think this entire if block should be removed. We don't care about terminalTotalDifficulty anymore. Note that if mergeForkBlock is set in the config, then both the Paris and the MergeForkIdTransition will point to that block (thus it is not necessary to set it again).
(But please re-test the hive test if this is changed :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two things:
terminalTotalDifficulty(TTD) fieldThese two changes are necessary in being able to parse and import blockchain data correctly when the deprecated TTD field is being used.
Thanks to @acolytec3 and @jochem-brouwer for their invaluable contributions in debugging this issue.