Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy and pasted from sample tweet to test #38

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

IstoraMandiri
Copy link
Collaborator

No description provided.

@IstoraMandiri
Copy link
Collaborator Author

IstoraMandiri commented Sep 13, 2022

@gitr0n1n @W1g0

I think I found the issue with the last retweet, the only difference in formatting is that there is a trailing space in @W1g0 's last tweet.

This tweet; notice no space after --- https://github.com/ethereumclassic/twitter-together/pull/38/files#diff-5cdb3ca77beaa751ecbb384fd0498f960e1376319aa618b8147e3076f7d5e7f4R3

@W1g0's tweet - notice extra space on last line after --- https://github.com/ethereumclassic/twitter-together/pull/35/files#diff-b4801db7433f87c66abd15e3d6c508855ce8dbda918d585c8c4b320ab1630eb6R3

In future for we can check the content of the preview tweet by checking the actions checks tab and looking at preview.

This one - notice no content
https://github.com/ethereumclassic/twitter-together/actions/runs/3048903344/jobs/4914444416#step:5:10

@W1g0 's retweet - notice the retweet content
https://github.com/ethereumclassic/twitter-together/actions/runs/3043658608/jobs/4903165538#step:5:10

Obviously, the app should still parse things the same and this can be fixed by removing trailing whitespace, which I will create an issue for, but we inherited this bug from experimental fork of twitter-together https://github.com/gr2m/twitter-together/pull/177

@ghost
Copy link

ghost commented Sep 14, 2022

Awesome work @IstoraMandiri 😎

@IstoraMandiri IstoraMandiri merged commit e162b22 into main Sep 14, 2022
@IstoraMandiri IstoraMandiri deleted the IstoraMandiri-patch-2 branch September 14, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant