Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returndatacopy_after_failing_delegatecallFiller #1420

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix returndatacopy_after_failing_delegatecallFiller #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...ralStateTestsFiller/stReturnDataTest/returndatacopy_after_failing_delegatecallFiller.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
"currentTimestamp" : "0x03e8"
},
"pre" : {
"0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this account for and why have you removed it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test apparently had a typo. and was calling this empty account instead of account with the actual code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the main bug, but not sure why this account was in the test.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste error. the test was not doing anything

"balance": "0x100000",
"code": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I think here would have been the call to 100...1 which fails. and then sstore[1] = 1 to indicate that the test worked

"nonce": "0x00",
"storage": {}
},
"0x1000000000000000000000000000000000000001": {
"balance" : "0x00",
"code": "{ (DELEGATECALL 10000 0x1000000000000000000000000000000000000002 0 0 0 0) (RETURNDATACOPY 0x0 0x0 32) ( SSTORE 0 (MLOAD 0))}",
Expand Down Expand Up @@ -64,7 +58,7 @@
"gasPrice" : "0x0a",
"nonce" : "0x00",
"secretKey" : "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8",
"to" : "0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6",
"to" : "0x1000000000000000000000000000000000000001",
"value" : [
"0x00"
]
Expand Down