Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix returndatacopy_after_failing_delegatecallFiller #1420

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix returndatacopy_after_failing_delegatecallFiller #1420

wants to merge 1 commit into from

Conversation

0xVolosnikov
Copy link
Contributor

Fixes #1417

@winsvega
Copy link
Collaborator

winsvega commented Jan 8, 2025

rebase
need to refill the tests and I would guess then expect section needs a correction as well.
thanks!

@winsvega
Copy link
Collaborator

winsvega commented Jan 8, 2025

or can just plain convert it into pyspecs

chfast
chfast reviewed Jan 20, 2025
View reviewed changes
...eneralStateTestsFiller/stReturnDataTest/returndatacopy_after_failing_delegatecallFiller.json
@@ -8,12 +8,6 @@
"currentTimestamp" : "0x03e8"
},
"pre" : {
"0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this account for and why have you removed it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test apparently had a typo. and was calling this empty account instead of account with the actual code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the main bug, but not sure why this account was in the test.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste error. the test was not doing anything

@chfast
Copy link
Member

chfast commented Jan 22, 2025

This also affects legacy tests.

winsvega
winsvega reviewed Jan 22, 2025
View reviewed changes
...eneralStateTestsFiller/stReturnDataTest/returndatacopy_after_failing_delegatecallFiller.json
@@ -8,12 +8,6 @@
"currentTimestamp" : "0x03e8"
},
"pre" : {
"0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6" : {
"balance": "0x100000",
"code": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I think here would have been the call to 100...1 which fails. and then sstore[1] = 1 to indicate that the test worked

@winsvega
Copy link
Collaborator

Detected error: return data out of bounds this is the vm error on such tests.
I assume if the test is incorrect we can as well just remove it from legacy tests too.
when we port on python it should be better checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega left review comments

@chfast chfast chfast left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid to in returndatacopy_after_failing_delegatecallFiller
3 participants
@0xVolosnikov @winsvega @chfast