Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add typings to npm package #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add typings to npm package #693

wants to merge 1 commit into from

Conversation

roninjin10
Copy link

  • add .d.ts files to final build with declaration: true in tsconfig
  • include .d.ts file in final tarball

This was referenced May 28, 2023
Open
Open
@coveralls
Copy link

Coverage Status

Coverage: 84.537%. Remained the same when pulling 0ede118 on roninjin10:master into 9f3d555 on ethereum:master.

@CoolColdUK
Copy link

CoolColdUK commented Jul 16, 2023 •
edited
Loading

maybe need types in package.json as well?
image
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

@yiyi-wang-rv
Copy link

yiyi-wang-rv commented Sep 11, 2023 •
edited
Loading

Any update to this PR? 👀

@roninjin10
Copy link
Author

Happy to help land this pr if any changes are requested

@just-mitch just-mitch mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roninjin10 @coveralls @CoolColdUK @yiyi-wang-rv