Add CI job to check if updateBinary downloads the correct release #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
requested changes
Sep 20, 2022
cameel
reviewed
Sep 23, 2022
cameel
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
There's still #659 (comment) left to resolve but this is not a major issue so I'm already approving. Fine to merge whether you decide to go with my suggestion there or not.
|
Before merging please squash the commits a bit. Does not have to be just one but in this case this seems like the best option.It all looks like review fixes and we usually squash those into the original commits they change. |
r0qs
force-pushed
the
test-download-latest-version-ci
branch
2 times, most recently
from
2b11884
to
b18711d
Compare
r0qs
force-pushed
the
test-download-latest-version-ci
branch
from
6e17949
to
aca5193
Compare
Co-authored-by: Kamil Śliwak <[email protected]>
r0qs
force-pushed
the
test-download-latest-version-ci
branch
from
aca5193
to
1283652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the comments made here #648 (comment) and is part of the solution for the issue #632.
It adds a CI job to test if the current version is equal to the downloaded release when using the
updateBinarycommand.