Change rules for selecting filename for generated files #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Nov 13, 2018
solcjs
Outdated
| @@ -115,7 +115,7 @@ function writeFile (file, content) { | |||
| } | |||
|
|
|||
| for (var contractName in output.contracts) { | |||
| var contractFileName = contractName.replace(/[:./]/g, '_'); | |||
| var contractFileName = contractName.replace(/(.*):/, ''); | |||
There was a problem hiding this comment.
What happens in case of collisions?
|
solc is looking for collisions. If there are none, it uses the contract name, otherwise the fully qualified name with |
|
@chriseth okay i can recrete this behaviour in solcjs. I just think that current state of things is wrong. |
|
@krzkaczor it would be appreciated. Please also rebase :) |
|
Hi, I believe we can have this. And maybe add a @krzkaczor would you like to finish this, or should we take it over? |
|
@r0qs please, take over :) |
r0qs
force-pushed
the
kk/fix-cli-output-filename
branch
2 times, most recently
from
be371c2
to
db0e88f
Compare
r0qs
force-pushed
the
kk/fix-cli-output-filename
branch
from
db0e88f
to
8c6f1af
Compare
r0qs
force-pushed
the
kk/fix-cli-output-filename
branch
from
8c6f1af
to
fd73c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219.
Behaviour is now the same as for native
solc.EDITED by @r0qs:
I pushed my attempt to finish this PR. It adds the
overwriteflag and tests to it.The first commit was necessary to allow the tests to clean the
.binand.abiartifacts generated by the test cases. Before, they weren't clean after each run, and with the addition of the overwrite functionality, they would not work.