optimize serialization of single-slot leaves #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
approved these changes
Apr 26, 2024
| @@ -86,6 +88,8 @@ func ParseNode(serializedNode []byte, depth byte) (VerkleNode, error) { | |||
| return CreateInternalNode(serializedNode[internalBitlistOffset:internalCommitmentOffset], serializedNode[internalCommitmentOffset:], depth) | |||
| case eoAccountType: | |||
| return parseEoAccountNode(serializedNode, depth) | |||
| case singleSlotType: | |||
There was a problem hiding this comment.
Add bullet to method's comment. (Be aware that base branch has a similar comment)
tree.go
Outdated
Comment on lines
1819
to
1818
| baseSize := nodeTypeSize + StemSize + 2*banderwagon.UncompressedSize + leafValueIndexSize + leafSlotSize | ||
| result = make([]byte, baseSize) |
There was a problem hiding this comment.
Similar suggestion as in base branch. baseSize is constant, so we can avoid make and prob avoid an allocation by using an array.
gballet
force-pushed
the
pack-leaf-with-single-slot
branch
from
dd9ba8e to
c6236f8
Compare
gballet
added a commit
that referenced
this pull request
Jun 26, 2024
* special serialization for EoAs * fix breaking test * reduce the flexibility of the encoding * optimize serialization of single-slot leaves (#433) * pack single slot leaf * silence linter * review feedback * review feedback * Apply suggestions from code review Co-authored-by: Ignacio Hagopian <[email protected]> * linter fix --------- Co-authored-by: Ignacio Hagopian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another serialization optimization, for the case of a single leaf.
This could be extended to a group of leaves.