Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/filters: ensure filter api timeout loop terminates with filter event system termination #31056

Merged
merged 1 commit into from
Jan 21, 2025
Merged

eth/filters: ensure filter api timeout loop terminates with filter event system termination #31056

merged 1 commit into from
Jan 21, 2025
+5 −1

Conversation

jwasinger
Copy link
Contributor

Discovered from failing test introduced #31033 . We should ensure timeoutLoop terminates if the filter event system is terminated.

MariusVanDerWijden
MariusVanDerWijden approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@fjl fjl merged commit 6c10996 into ethereum:master Jan 21, 2025
2 of 3 checks passed
@fjl fjl modified the milestones: 1.14.13, 1.15.0 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jwasinger @MariusVanDerWijden @fjl