params,core: add max and target value to chain config #31002
+590
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jan 8, 2025
fjl
reviewed
Jan 9, 2025
lightclient
requested review from
holiman,
karalabe,
gballet,
rjl493456442,
zsfelfoldi,
MariusVanDerWijden,
s1na and
jwasinger
as code owners
eth/tracers/internal/tracetest/testdata/prestate_tracer/setcode_tx.json
Outdated
Show resolved
Hide resolved
|
Made the updates from your review, Marius. Thanks! |
lightclient
commented
Jan 11, 2025
| @@ -26,7 +26,7 @@ import ( | |||
| "github.com/holiman/uint256" | |||
| ) | |||
|
|
|||
| var rand = mrand.New(mrand.NewSource(1)) | |||
| var rnd = mrand.New(mrand.NewSource(1)) | |||
There was a problem hiding this comment.
I renamed this because it was playing havoc with my LSP for some reason.
lightclient
force-pushed
the
eip-7840
branch
4 times, most recently
from
5df556c to
c3daabe
Compare
lightclient
commented
Jan 21, 2025
params/config.go
Outdated
| // requested time. | ||
| func (c *ChainConfig) TargetBlobsPerBlock(time uint64) uint64 { | ||
| if c.BlobScheduleConfig == nil { | ||
| panic("blob schedule not defined") |
There was a problem hiding this comment.
Should try to remove these panics and put a check in the fork order checker.
s1na
reviewed
Jan 21, 2025
fjl
reviewed
Jan 23, 2025
|
|
||
| // CheckConfigBlobSchedule checks that all forks with blobs enabled explicitly | ||
| // define the blob schedule configuration. | ||
| func (c *ChainConfig) CheckConfigBlobSchedule() error { |
There was a problem hiding this comment.
Why is this not in CheckConfigForkOrder? If we introduce another function we have to call it everywhere. This check is also kind of related to the 'fork order', so it would fit perfectly into the other function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements EIP-7840 and EIP-7691.