-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): json schema verification #968
Open
winsvega
wants to merge
6
commits into
main
Choose a base branch
from
verification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
added
good first issue
Good for newcomers
type:test
Type: Add/refactor fw unit tests; no fw or el client test case changes
type:feat
type: Feature
labels
Nov 22, 2024
winsvega
force-pushed
the
verification
branch
from
November 27, 2024 11:06
1538efd
to
31273b7
Compare
winsvega
changed the title
json schema verification
feat(tests): json schema verification
Nov 27, 2024
winsvega
force-pushed
the
verification
branch
from
December 4, 2024 10:47
3e8a429
to
80a49e6
Compare
danceratopz
reviewed
Dec 4, 2024
winsvega
force-pushed
the
verification
branch
from
December 11, 2024 12:16
ee69e26
to
e014743
Compare
winsvega
force-pushed
the
verification
branch
2 times, most recently
from
January 16, 2025 10:43
4563bf9
to
04d3ffd
Compare
winsvega
force-pushed
the
verification
branch
2 times, most recently
from
January 17, 2025 11:53
727d236
to
88473f3
Compare
winsvega
force-pushed
the
verification
branch
from
January 17, 2025 11:57
88473f3
to
bf63446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
type:feat
type: Feature
type:test
Type: Add/refactor fw unit tests; no fw or el client test case changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Pydanticfy the json schemas so we verify the quality of generated test fixtures
This is an MVP to catch what I think is the cause of bug
pyspecs with evmone-t8n export extra field on all forks which should not be there. perhaps this extra field leads to wrong block init in its' t8n when we blindly feeding the env section. and to a wrong state hash in my test scenarios.
so the issue is
evmone-t8n return
on all forks. and we export it to the final test. when this field is only in blockheader in exported test since London
🔗 Related Issues
#940
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.