feat(forks,tests): Add EIP-7623 #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
reviewed
Dec 10, 2024
tests/prague/eip7623_increase_calldata_cost/test_transaction_validity.py
Outdated
Show resolved
Hide resolved
winsvega
reviewed
Dec 10, 2024
tests/prague/eip7623_increase_calldata_cost/test_transaction_validity.py
Outdated
Show resolved
Hide resolved
winsvega
reviewed
Dec 10, 2024
tests/prague/eip7623_increase_calldata_cost/test_transaction_validity.py
Show resolved
Hide resolved
winsvega
reviewed
Dec 10, 2024
tests/prague/eip7623_increase_calldata_cost/test_transaction_validity.py
Show resolved
Hide resolved
winsvega
reviewed
Dec 10, 2024
tests/prague/eip7623_increase_calldata_cost/test_transaction_validity.py
Outdated
Show resolved
Hide resolved
winsvega
reviewed
Dec 10, 2024
There was a problem hiding this comment.
added some comments, quick review
this is a good eip for transaction tests. in tx tests we assume that intrinsic gas rules are still checked. so if tx deserialization is ok, but didn't pass intrinsic gas check such tx test is invalid tx.
by playing with transaction format in any way we want we can parametrize transaction fields in transaction test
not building env,pre,blocks
reedsa
reviewed
Dec 17, 2024
Co-authored-by: Stuart Reed <[email protected]>
marioevz
commented
Dec 18, 2024
danceratopz
approved these changes
Dec 18, 2024
Co-authored-by: danceratopz <[email protected]>
codeofcarson
pushed a commit
to codeofcarson/execution-spec-tests
that referenced
this pull request
Jan 24, 2025
* feat(forks): Add EIP-7623 logic to gas calculation * fix(tests): Broken tests due to gas cost change * feat(forks): Add `transaction_data_floor_cost_calculator` * new(tests): EIP-7623: Add transaction validity tests * review comments * new(tests): EIP-7623: Add gas consumption tests * refactor(tests): EIP-7623: minor refactor * Update src/ethereum_test_forks/base_fork.py Co-authored-by: Stuart Reed <[email protected]> * Update src/ethereum_test_forks/base_fork.py * Apply suggestions from code review Co-authored-by: danceratopz <[email protected]> * fix(forks): tox * docs: changelog --------- Co-authored-by: Stuart Reed <[email protected]> Co-authored-by: danceratopz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds tests for EIP-7623: Increase calldata cost.
Framework changes
Modifies
transaction_intrinsic_cost_calculatorthat is returned by the fork objects to account for the extra intrinsic cost that the EIP adds.Also a new parameter is added to the function in order to return different values depending on how the function is used:
Fix Existing Tests
Some tests were broken because they needed a transaction to start with a deterministic amount of gas and also with a given calldata length.
Solution to most of these issues was to add an access list so the intrinsic gas cost exceeded the new floor data cost.
🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.