Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-module build #388

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

dwhjames
Copy link
Contributor

The main aim here is to remove log4j and main
classes from compile scope in the core library.

This will help integrate ethereumj-core as a library
into projects that don’t choose to use log4j and
want to use a different logging framework to back
slf4j.

Problems encountered:
org.ethereum.util.AdvancedDeviceUtils uses log4j
to dynamically change the logging config. There was
no resolution other than to remove this.

update to gradle and wrapper script

The main aim here is to remove log4j and main
classes from compile scope in the core library.

This will help integrate ethereumj-core as a library
into projects that don’t choose to use log4j and
want to use a different logging framework to back
slf4j.


Problems encountered:
`org.ethereum.util.AdvancedDeviceUtils` uses log4j
to dynamically change the logging config. There was
no resolution other than to remove this.
@dwhjames
Copy link
Contributor Author

@Nashatyrev, as discussed on
https://gitter.im/ethereum/ethereumj?at=5719093c98c544f1396d516a

Here’s my first attempt at this. I’m far from a Gradle expert—happy to hear suggestions for improvements.

@Nashatyrev
Copy link
Member

Many thanks for this PR! I like this modular approach, though need to discuss with the team if we have any fallbacks here

the build task needs `mainClassName` to be defined
@dwhjames
Copy link
Contributor Author

I think there’s probably room for further improvement, but I got this far enough to accomplish my original goal of tidying up what was on the classpath for the core library.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 58.316% when pulling bc6cdfb on gemini:topic/sub-projects into 2199165 on ethereum:develop.

@dwhjames
Copy link
Contributor Author

Resolved the merge conflict in 30b78d4

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 58.346% when pulling 30b78d4 on gemini:topic/sub-projects into 33fcacb on ethereum:develop.

@Nashatyrev
Copy link
Member

@romanman I believe you were going to comment on this PR

@Honestnode2
Copy link

Trying to master the Trivial pursuit of coding and creating an equal opportunity for all to access funds at time of need

@erockoms
Copy link

erockoms commented May 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants