Deprecate the keccak function #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just added support for text/hex to eth_hash's version, but that has a significant performance impact and was not really used anywhere, so deprecating it now so that it can be removed in a future version. Closes: ethereum#95
|
I'm proposing that we do not remove this functionality or deprecate it to continue exposing a high level |
reedsa
pushed a commit
to reedsa/eth-utils
that referenced
this pull request
Sep 18, 2023
reedsa
added a commit
that referenced
this pull request
Sep 21, 2023
* bump docs dependencies * new github issue and pr templates (#75) * new issue and pr templates * convert bash scripts to py (#77) * convert bash scripts to py * Various template default updates (#74) * bump versions in dependencies and ci builds * move tox to [dev] per issue #34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps * remove outdated sections of README (#76) * remove gitter, testing setup, and pandoc sections, add quotes to dev install * repin flake8 and misc updates (#79) * repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates * template cleanup following initial merge with py-evm (#80) * template cleanup following initial merge with py-evm * add flake8 pin comment * correct license years * add pin note to mypy * apply template updates found following merge with eth-typing (#81) * apply template updates found following merge with eth-typing * add build as a dev dependency * remove timeout from pytest.ini, it doesn't do anything without pytest-timeout as a dep * Template updates post ssz and ethabi (#82) * add updates found when merging template with py-ssz and eth-abi * add wheel and wheel-windows to ci and reorg * upgrade pip and remove --user from tox install during ci (#85) * introduce contributing doc + main branch convention (#84) * update tox calls to use run, update all pip calls to use python -m (#86) * Remove testall (#88) * remove testall because it doesnt work * minor formatting updates, remove contributing docs * bump sphinx version and set py version rtd uses to 3.8 * change references to doc to all be docs * Update .gitignore spelling error * fix typos in ci config and Makefile * Add tests to distribution by default (#97) * Update release command to check remote for upstream * Update .gitignore add `.venv*` to .gitignore * ignore flake8 F401 errors in __init__.py files * Conflicts fixed in .github * Clean up F401 * Newsfragment * docs fixes * Fix install command --------- Co-authored-by: pacrob <[email protected]> Co-authored-by: Paul Robinson <[email protected]> Co-authored-by: Marc Garreau <[email protected]> Co-authored-by: kclowes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just added support for text/hex to eth_hash's version, but that has a
significant performance impact and was not really used anywhere, so
deprecating it now so that it can be removed in a future version.
Closes: #95