Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning for missing networks #288

Open
wants to merge 5 commits into
base: 2.x
Choose a base branch
from

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Oct 22, 2024

What was wrong?

Network warnings visible when the network constants are out of date. There is no need to send warnings, especially since the core networks are already present. If a new network is needed, the script can be run separately to update the networks file.

How was it fixed?

Remove the warning for missing networks and allow initialization from the network list.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa changed the base branch from main to 2.x October 22, 2024 16:51
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I wouldn't worry about the windows wheel - this is old enough that we were relying on Circle CI images to have python versions installed rather than installing them ourselves, and py3.11 must have been removed

@reedsa
Copy link
Contributor Author

reedsa commented Oct 22, 2024

Oh okay that's great news! Thanks for the review @pacrob 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants