Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Electra fork-digest for BeaconBlocksByRange/Root v2 #4083

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Document Electra fork-digest for BeaconBlocksByRange/Root v2 #4083

merged 1 commit into from
Jan 16, 2025

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jan 16, 2025

Documents Electra fork-digest for BeaconBlocksByRange/Root v2, while there are no other changes, this seems to be missing compared to previous forks since we modified BeaconBlockBody in Electra which changes SignedBeaconBlock.

jtraglia
jtraglia approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, good catch. Thank you!

PS: the order of these endpoints isn't consistent. We do range, then root for blocks and root, then range for blobs. I'll make a follow up PR which fixes this. This applies to Deneb too.

@jtraglia jtraglia merged commit 17997c1 into ethereum:dev Jan 16, 2025
23 checks passed
@jtraglia jtraglia mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @jtraglia