Code

Fix findings from Dmitry's review#508

Code

Merged

jtraglia merged 21 commits intoethereum:mainethereum/c-kzg-4844:mainfrom jtraglia:dmitry-reviewjtraglia/c-kzg-4844:dmitry-reviewCopy head branch name to clipboardSep 25, 2024

+303-142

Commits

Commits on Sep 16, 2024

• Start to fix findings from Dmitry's review

  jtraglia

  committed
  518b2ea

  Copy full SHA for 518b2ea

• Replace int variables with size_t variables

  jtraglia

  committed
  2c03989

  Copy full SHA for 2c03989

• Optimize away a blst_fr_eucl_inverse call

  jtraglia

  committed
  1c67090

  Copy full SHA for 1c67090

• Precompute reverse-bits-limited cell indices

  jtraglia

  committed
  3187576

  Copy full SHA for 3187576

• Fix mistake

  jtraglia

  committed
  e328423

  Copy full SHA for e328423

• Remove accidental line break

  jtraglia

  committed
  742fec2

  Copy full SHA for 742fec2

• Add asserts for domain string lengths

  jtraglia

  committed
  37eea2c

  Copy full SHA for 37eea2c

Commits on Sep 17, 2024

• Revert changes to fr_batch_inv & bytes_from_uint64

  jtraglia

  committed
  116ba8f

  Copy full SHA for 116ba8f

Commits on Sep 18, 2024

• Rename inv_len to inv_n

  jtraglia

  committed
  87068fb

  Copy full SHA for 87068fb

• Move FIELD_ELEMENTS_PER_EXT_BLOB to cell.h

  Show description for 7cf99f2
  jtraglia

  committed
  7cf99f2

  Copy full SHA for 7cf99f2

• Clean up toeplitz_coeffs_stride

  jtraglia

  committed
  c9f6845

  Copy full SHA for c9f6845

• Rename field_element to element_bytes

  jtraglia

  committed
  df5e7e5

  Copy full SHA for df5e7e5

• Maybe improve readability for coset factors

  jtraglia

  committed
  8f381e9

  Copy full SHA for 8f381e9

• Add length info to comments

  jtraglia

  committed
  8c9d0ab

  Copy full SHA for 8c9d0ab

Commits on Sep 19, 2024

• Add punctuation to new comment

  Show description for 7a0d72e
  

  jtraglia

  and

  b-wagn

  authored
  7a0d72e

  Copy full SHA for 7a0d72e

• Fix length comment

  Show description for 2a62ef3
  

  jtraglia

  and

  b-wagn

  authored
  2a62ef3

  Copy full SHA for 2a62ef3

• Replace / 2 with / EXPANSION_FACTOR

  jtraglia

  committed
  021730e

  Copy full SHA for 021730e

• Remove EXPANSION_FACTOR constant

  jtraglia

  committed
  4e4ce18

  Copy full SHA for 4e4ce18

Commits on Sep 20, 2024

• Improve coset factor computation (#7)

  asn-d6

  authored
  64b156c

  Copy full SHA for 64b156c

• Add extra assert & fix formatting

  jtraglia

  committed
  94c1314

  Copy full SHA for 94c1314

• Format c params

  jtraglia

  committed
  353cb4f

  Copy full SHA for 353cb4f