Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload python wheels on Linux runner #404

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Mar 4, 2024

So I made a mistake. gh-action-pypi-publish only works on Linux. So when this action ran, it failed when trying to publish the macOS packages and cancelled the other platform workflows.

Also, I didn't realize there were multiple types of "releases" like "created", "published", etc. This PR adds a line which should cause this to only run once when a release is made.

image

@jtraglia
Copy link
Member Author

jtraglia commented Mar 4, 2024

I thought I would be able to publish via a PR. Probably good this isn't possible.

image

I will merge & get an admin to run this action manually. So we don't need to create a new release.

@jtraglia jtraglia changed the title Publish python package with twine Upload python wheels on Linux runner Mar 4, 2024
@jtraglia jtraglia merged commit 4d3fb9a into ethereum:main Mar 4, 2024
34 checks passed
@jtraglia jtraglia deleted the publish-with-twine branch March 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant