-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable blst portable by default #389
Conversation
Hey @Rjected thanks for the PR. This might have actually been an oversight on our part. The other bindings are using the portable version of blst by default, with the exception of Go because we can't control it from here. Semi-recently, the authors of blst added "cpu runtime detection" to the portable version of blst; so if the system is using a new cpu it will use optimized instructions and if it's an older cpu it will use the portable implementation. This is a long way of saying we should be using portable by default. |
Ah, interesting, that's actually pretty great, because it means we don't have to do anything differently between release binaries and building from source. Does this mean we should set |
Yes, and I slightly favor the second one but it's not a strong opinion. |
makes sense, I just changed it to the second one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again! I will wait for another maintainer to approve before merging.
Thanks a lot! |
This is so we can enable the underlying blst
portable
feature in reth for creating portable release binaries