Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed x86_64-pc-windows-gcc build for rust bindings #384

Merged
merged 1 commit into from Dec 14, 2023
Merged

Fixed x86_64-pc-windows-gcc build for rust bindings #384

merged 1 commit into from Dec 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2023

Fixed rust bindings build from windows-gcc toolchain

#354 (comment)

cc @jtraglia @asn-d6

@ghost
Copy link
Author

ghost commented Dec 14, 2023

x86_64-pc-windows-mevc build passes so I think it is good to go

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 nice and simple. Thanks for this!

@jtraglia jtraglia merged commit e266280 into ethereum:main Dec 14, 2023
34 checks passed
@ghost
Copy link
Author

ghost commented Dec 14, 2023

@jtraglia Just built the package using the x86_64-pc-windows-gcc tool and confirmed that this PR fixes the issue. Thank you for the quick merge!

@ghost ghost mentioned this pull request Dec 14, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant