-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions #3
Conversation
Hey @MatthiasLohr, that looks good! Thanks for setting it up. I can probably take it from here to wire up the rest of the pipeline that pushes the releases to pypi. But actually, I'll need your help here @davesque. I don't have administrative rights in this repository to setup secrets which we need to do to push into PyPi. I see three possible ways forward and all of them are fine to me:
1, 2 and 3 are ordered from most hassle on your end to most hassle on my end 😂 What would you prefer? |
I know I'm not eligible to vote... but I vote for option 3! (also considering the comment from @fubuloubu in #2). Btw, instead of forking, you could also "transfer" it to Ethereum group - so it would look more like the "main" repository. I usually check twice before I create a pull request - and mostly tend to open it again the "fork head" instead of some forks. |
Yeah, I can see why option 3 might be compelling but I also don't want to "steal" it if David wants to continue to maintain it. And thanks for the transfer suggestion, makes sense 👍 |
Any update on this...? |
@davesque Would you be ok to transfer ownership to the EF? I'm going to also send you an email just in case you aren't observing these messages here. |
@cburgdorf Hey, yeah I would be happy to transfer ownership. Sorry I haven't been paying much attention to this repo or the issues on it. Isn't there some process I have to follow for that? I seem to remember that I did something similar for the rust-vyper (now fe) repo and had some interactions with @holiman regarding that. Maybe that was in the ethereum meta issues repo. |
Thanks, happy to hear! It sounds like that you would need to have rights to create repositories in the EF organization to be allowed to make the transfer. So maybe someone from devops needs to be added as an owner to this repo first. The transfer has the blessing from @pipermerriam. I'll create an issue in the EFs devops system to see who can assist us with the transfer. |
Hey, any progress here? |
@cburgdorf Alright, there was no option to make @Aldekein an admin since this is a personal repo. So I just transferred the repo to him. I think he can finish the process of transferring it to the EF. |
Thanks, that should work 👍 |
Migration worked, thanks! I still need to get access to the management of the environment variables exposed to Github Actions to complete the process but we should soon be able to wrap this up :) |
Hi, sorry to bother you again, but I really would like to see that fixed... ;) |
Yep, me too. I pinged devops again today because I'm still lacking the administrative rights to setup the pypi token. I'll keep pushing this week :) |
@cburgdorf now you have administrative rights for the blake2b-py repo. Sorry for the delay! |
@Aldekein Thanks, everything is working fine now. @MatthiasLohr This now landed as part of #4 I also cut a new version |
Finally!!! Thanks :) And sorry for pushing so hard ;) |
This is a first draft of GitHub actions utilization. I never worked with GitHub actions before, so I'm not completely sure about the process of releasing/uploading artifacts to PyPI.