Add custody_group_count to metadata in node/identity response
#489
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
approved these changes
Jan 22, 2025
nflaig
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
I guess we did the same for syncnets in #150 to add it as an optional field.
The problem with this approach is that it makes returning a ssz response more complicated, although as per spec this api only supports json.
I would be in favor of bumping the api version if we add new properties to data object but this seems reasonable as well since we used the same approach before.
michaelsproul
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
custody_group_countto metadata.This field is part of
MetaDataV3used by PeerDAS and will be available from the Fulu fork.https://github.com/ethereum/consensus-specs/blob/e79ef816aef05e34eff0b53311cf50c13fb67fc9/specs/fulu/p2p-interface.md?plain=1#L159